Improve the inputs #143
Merged
Improve the inputs #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Coverage SummaryResults for commit: 9e1ed5f Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Totto16
force-pushed
the
input-improvements
branch
from
047c496 to
e10ae38
Compare
Totto16
force-pushed
the
input-improvements
branch
from
8575150 to
33e2cbf
Compare
- remove capabilities functions and make new input manager / input handlers, that hide cross platform stuff - name mouse / touch inputs pointer events - add navigation events - add menu commands (toggleable) - add SDL_key + SDL_Keymod wrapper - handle special inputs correctly - add joystick wrappers, that work on every platform - refactor some major logic in the input handling for the game / navigation - refactor settings - require git to always have git information
… will be fixed later)
- serialize and deserialize them all - use the settings to make TouchGameInput dynamic
…erializing / deserializing them
…he input manager and called by static methods, that also have an argument of the input array, this is done to have this functionality in the joystick input file, but use it in this place
…es.cpp -> platform.cpp
- refactor const_utils - refactor expected, it now can take two template arguments and uses a bool to keep track of the state - refactor the color literal parsing due to the above changes
- fix from_string / to_string
- throw error in cases, we need to describe unsupported navigation events instead of returning a string, that says, that it's unsupported
- correct the sdl_key tests - check for the m_instance_id on all joystick events
- add more sdl_key tests - fix display functions for helper::optional and helper::expected for gtest
- fix few error paths in "SDL::Key::from_string" - fix SDL::Key::has_modifier_exact
- correct the default settings - correct the settings.json file
Totto16
force-pushed
the
input-improvements
branch
from
fb1d127 to
d5119ca
Compare
- make a abstract class, that describes which methods a new console joystick has to have - deduplicate the same logic of 3ds / switch game input
fix 3ds and switch, so that the linker is fix, it didn't work with a custom linker override locally previously (e.g. mold)
- refactor how settings and controls are treated: - you can just use the primary input or you can set an array and an index, that is than used, but if that fails in some way, nothing else is tested. - each input takes loaded settings or default ones,so specifying a controls array and no "selected" index is useful, since than it uses the setting suited for the primary input
add joystick axis support
- fix all todos. add a name to them
- fix many errors
7 tasks
- fix more errors
- fix more errors
- add support for switch joystick, by adding the guid - also add guid and name in default settings
- fix more errors
- fix name errors: namespace SDL -> sdl
- fix more errors
- fix more errors
- fix console build, by providing missing function definition
- fix more errors - remove duplicate call to get_menu_event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #54